Fix window title drawn outside the title bar #107305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
changed the title
timothyqiu
force-pushed
the
single-window-title
branch
from
3219c33 to
b99c5c7
Compare
bruvzg
approved these changes
Jun 9, 2025
AThousandShips
approved these changes
Jun 9, 2025
timothyqiu
force-pushed
the
single-window-title
branch
from
b99c5c7 to
f028bc9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the problem is that drawing text with a negative trimming width means disabling clipping & trimming.
As you've noticed, the close button can also go outside the window. This PR leaves the close button alone as the proper solution is to limit the window's width. But doing that breaks compatibility.
Also documented the information I found when inspecting this issue.