Skip to content

ItemList: Fix text drawing not taking h_separation into account in top mode. #107333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

Jordyfel
Copy link
Contributor

@Jordyfel Jordyfel commented Jun 9, 2025

Fixes #107325

The code to do this exists, but is unreachable. Removes the unreachable code and the size2 local variable that was used only once.

Before:
Image

After:
image

The appearance could probably use further improvements.

@Jordyfel Jordyfel requested a review from a team as a code owner June 9, 2025 17:42
@AThousandShips AThousandShips added bug topic:gui cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 10, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 10, 2025
@Repiteo Repiteo merged commit cbdeaee into godotengine:master Jun 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 24, 2025

Thanks!

@Jordyfel Jordyfel deleted the itemlist-text-drawing branch June 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the filesystem dock in thumbnail grid mode, file names are very hard to read because of complete lack of separation between elements.
4 participants