Skip to content

Fix external Material for invalid Material #107339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented Jun 9, 2025

Salvaged and rebased from #64903, which has not updated in 3 years. Original author credited in commit.

Fixes #64853
Fixes #64970
Supersedes and closes #64903

@DeeJayLSP DeeJayLSP requested a review from a team as a code owner June 9, 2025 23:56
Copy link
Contributor

@jss2a98aj jss2a98aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as it should on my machine. The artists I work with will be very happy if this is merged.
Edit: Adding "Closes #64903" to the description would probably be a good idea.

@fire fire moved this to Pending, No consensus in Asset Pipeline Issue Triage Jun 10, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 10, 2025
@AThousandShips AThousandShips added cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 10, 2025
@lyuma
Copy link
Contributor

lyuma commented Jun 10, 2025

The problem with this implementation is some objects have a ton of unnamed meshes without materials, and if I click the extract button, I'm going to end up with hundreds of the same blank material files extracted to the project, which I don't want.

So it would be nice to by default extract one material file, but then allow overriding materials.
I think the plan to move forward with this might be to finish up reduz' workflow for material editing from the 3D import dialog from here: #107351 - it adds some support for handling of unnamed materials.

Once we have the material editing dialog, we can then look again at this bug and see if it can be fixed in a way that will allow overriding materials per-mesh or per-material, without spitting out tons of empty material files when I extract all.

@lyuma lyuma modified the milestones: 4.5, 4.x, 4.6 Jun 10, 2025
@lyuma lyuma added enhancement and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release bug labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending, No consensus
6 participants