Skip to content

Visual feedback update for viewport rotation gizmo. #107343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kj-art-dev
Copy link
Contributor

This PR is related to issue godotengine/godot-proposals#11496

I’ve updated how the axes highlight when users interact with the viewport rotation gizmo. The positive axis text highlights when hovered, and the negative axis text will display when the cursor hovers over a negative axis.

Godot_viewport_rotation_gizmo_visual_feedback_update_01.mp4

@kj-art-dev kj-art-dev requested a review from a team as a code owner June 10, 2025 03:15
@fire fire requested a review from a team June 10, 2025 03:27
@AThousandShips AThousandShips added this to the 4.x milestone Jun 10, 2025
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change.
However, it looks like it depends on the editor scale. While the text is centered for 200% editor scale, it looks off for 100%:

image

@kj-art-dev
Copy link
Contributor Author

I like this change. However, it looks like it depends on the editor scale. While the text is centered for 200% editor scale, it looks off for 100%:

image

Thanks for bringing this to my attention! I'm working on a fix for this.

@kj-art-dev kj-art-dev force-pushed the viewport-rotation-control-visual-feedback branch from ea356fe to cd46dfd Compare June 10, 2025 21:13
@kj-art-dev
Copy link
Contributor Author

I’ve just pushed an update. The text for the negative axes should have better alignment at different editor scales now.

@kj-art-dev kj-art-dev force-pushed the viewport-rotation-control-visual-feedback branch from 036cca1 to 15f3437 Compare June 13, 2025 03:08
@fire fire requested a review from a team June 13, 2025 12:00
@kj-art-dev kj-art-dev force-pushed the viewport-rotation-control-visual-feedback branch 3 times, most recently from cbb3aae to 64f6b20 Compare June 19, 2025 07:06
@kj-art-dev kj-art-dev force-pushed the viewport-rotation-control-visual-feedback branch 2 times, most recently from 37ffc48 to 29b3815 Compare July 1, 2025 05:00
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

100% editor scale

gizmo_scale_100.mp4

175% editor scale

gizmo_scale_175.mp4

Adjusted highlight behavior for positive axes and added negative axis labels.
@kj-art-dev kj-art-dev force-pushed the viewport-rotation-control-visual-feedback branch from 29b3815 to 5f3a1e4 Compare July 4, 2025 20:00
@kj-art-dev
Copy link
Contributor Author

Thanks for taking the time to test and review this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants