Skip to content

Expose Node.can_auto_translate() #107344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jun 10, 2025

{Control,Window}.auto_translate has long been deprecated for Node.auto_translate_mode.

However, a substitute for the getter is never provided. This means that we have no easy way to tell whether a node auto translates for nodes that are neither Control nor Window, or for all nodes in a deprecated=false build.

@timothyqiu timothyqiu requested review from a team as code owners June 10, 2025 04:12
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 10, 2025
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@timothyqiu timothyqiu force-pushed the can-auto-translate branch from ce79a2a to 4e20e33 Compare June 11, 2025 03:27
@akien-mga akien-mga merged commit 875a097 into godotengine:master Jun 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the can-auto-translate branch June 11, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants