Skip to content

Fix script property of custom resources inherited from scripts are not saved #107355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

beicause
Copy link
Contributor

Fixes #107243. Also applies the same changes to ResourceFormatSaverBinaryInstance.

@beicause beicause requested a review from a team as a code owner June 10, 2025 12:38
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 10, 2025
@akien-mga akien-mga requested a review from RandomShaper June 10, 2025 12:45
@beicause beicause force-pushed the fix-resource-script-property-save branch from 1f56cc4 to 784823a Compare June 10, 2025 15:03
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a pretty serious regression, but this seems to solve it. LGTM 👍

@akien-mga akien-mga merged commit e9f5bd8 into godotengine:master Jun 12, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@beicause beicause deleted the fix-resource-script-property-save branch June 12, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources that inherit from a global class are not saved properly
4 participants