-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Enforce GDScript and C# dictionary spacing style guidelines in code samples #107357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce GDScript and C# dictionary spacing style guidelines in code samples #107357
Conversation
I... this is going to be real nasty for translators. |
44669ef
to
2911178
Compare
I'd be happy to close this if it would cause issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually not that invasive in hindsight. However, we need to argue about... nested dictionaries in a single line, because that's not explicitly mentioned in the style guide.
I'd say that nested dictionaries are covered by the style guide, if it was an exception it should have been mentioned, otherwise it applies by induction |
…amples Co-authored-by: A Thousand Ships <[email protected]> Co-authored-by: Micky <[email protected]>
b19eec5
to
11af23a
Compare
Thanks! |
Both the GDScript and the C# style guides state that a space should be added after opening braces and before ending braces in single-line dictionary declarations. This PR enforces that guideline in various code samples.
This PR does not change the style of the following:
foo({"some_key": "bar"})
)[{"godot": true}]
)