Fix Sprite2D error spam in exported project #107360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Jun 10, 2025
scene/2d/sprite_2d.cpp
Outdated
| #ifdef TOOLS_ENABLED | ||
| add_user_signal(MethodInfo("_editor_region_rect_enabled")); | ||
| #endif | ||
| if (Engine::is_editor_hint()) { |
There was a problem hiding this comment.
This evaluates to always false in non-tool build, so #ifdef shouldn't be needed.
There was a problem hiding this comment.
But the ifdef is a small optimization isn't it?
There was a problem hiding this comment.
By "shouldn't be needed" I meant that the compiler might optimize it out, because it's no-op. It's just a guess though.
akien-mga
approved these changes
Jun 12, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #106553
The signal only exists in editor build, but always gets emitted, resulting in error spam about non-existent signal in exported project.