Upgrade normal interpolators to FP32 to fix Adreno. #107364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarioSamo
force-pushed
the
adreno-fix-interpolators
branch
from
1232ad8 to
e53b67d
Compare
clayjohn
approved these changes
Jun 10, 2025
dsnopek
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
I tested with a modified version of the GDQuest TPS demo on the Quest 3, and this PR fixes the issue for me!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using explicit FP16 has revealed some unintentional behavior when testing on Adreno 740 (Quest 3). I have the feeling it is a driver issue at the moment, but @clayjohn theorizes other platforms might've upgraded us behind our backs to FP32 while this driver doesn't.
Either way, it shouldn't be breaking and it exhibits some interesting behavior where the coordinate is forced to a full value around each quadrant of the screen.