Skip to content

Ensure macOS shortcut overrides are used for web export on macOS #107372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure macOS shortcut overrides are used for web export on macOS #107372

wants to merge 2 commits into from
+71 −16

Conversation

roughbits01
Copy link
Contributor

Fixes #107371

@roughbits01 roughbits01 requested a review from a team as a code owner June 10, 2025 17:10
roughbits01
roughbits01 commented Jun 10, 2025
View reviewed changes
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 10, 2025
@roughbits01
Copy link
Contributor Author

I'm updating doc/classes/ProjectSettings.xml to fix the CI.

@roughbits01 roughbits01 force-pushed the shortcut-override-macos-web branch from 4308caf to 57662d0 Compare June 10, 2025 17:42
@roughbits01 roughbits01 requested a review from a team as a code owner June 10, 2025 17:42
@paddy-exe
Copy link
Contributor

paddy-exe commented Jun 10, 2025 •
edited
Loading

Tested on MacBook Air M2 with v4.5.dev.custom_build [19bb187]
The example you listed in the issue with option + delete still does nothing with the build of this PR. Also, the cmd + delete is not bound to the delete_all_to_right shortcut (see image) in the web editor it seems for me. If you bind it though it still won't work.

image

@roughbits01
Copy link
Contributor Author

@paddy-exe this is what I see on my side when I build and run (chrome) the web editor from my PR.

image

@adamscott
Copy link
Member

Weird. Some standard shortcuts seem to be the same as your overrides.

Capture d’écran, le 2025-06-11 à 13 49 16

@AThousandShips AThousandShips changed the title MacOS shortcut overrides are used for web export on MacOS Ensure macOS shortcut overrides are used for web export on macOS Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug platform:web topic:input
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

MacOS shortcut overrides are not propagated to the web export
4 participants
@roughbits01 @paddy-exe @adamscott @AThousandShips