-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Add a proper error message when trying to add node to a group with an empty name #107375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and effective. This is my first review, do not take it into account like an experimented one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
Wording sounds good to me.
Looks good! Could you squash the commits? See PR workflow for instructions. |
Hopefully I did it correctly. |
Mostly good, but you kept the message of the last commit instead of the first one, so it's not fully accurate. You can change the commit message with |
Okay, thank you. Should be good now. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Right now, if you try to add a node to a group with an empty name, you will get a very unhelpful error
Condition "!p_identifier.operator String().length()" is true.
This pull request adds an error message "Tried to add node to a group with an empty name."
Minimal reproduction build:
error-message-test.zip