Skip to content

Add a LightmapProbe gizmo size editor setting #107382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 10, 2025

  • Decrease default size of LightmapProbe gizmos to make smaller-scale scenes with dense probes easier to edit.

cc @lander-vr

Preview

Before

godot_aJtEJ1DOIX

After

godot windows editor x86_64_fAVSRHVJfh

After (probe size set to 0.0 in editor settings)

godot windows editor x86_64_O1CJFxzBTu

- Decrease default size of LightmapProbe gizmos to make smaller-scale
  scenes with dense probes easier to edit.
@lander-vr
Copy link
Contributor

Nice! Works as expected. This is a really nice quality of life improvement.

image

I'm wondering if it'd be feasible to make probe size be based off of the distance towards neighboring probes?

I think it makes sense to have probes that cover a smaller area be smaller, while probes responsible for a larger area be larger, especially as we tackle improved automatic probe spawning behavior in the future.
E.g. imagine a sparse outdoor probe network with a dense indoor probe network, needing to restart the editor and adjust the size is probably not ideal in that scenario.

Another option could be to clamp the scale of the probes as the camera gets nearby, though, while that would be nice (and these suggestions aren't mutually exclusive), I don't think this would be as versatile as having variable probe sizes based on e.g. distance to closest neighboring probe.

@akien-mga akien-mga modified the milestones: 4.x, 4.5 Jun 12, 2025
@akien-mga akien-mga merged commit c66d89d into godotengine:master Jun 12, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-lightmapprobe-add-gizmo-size-setting branch June 12, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants