Skip to content

Fix the editor shortcuts for the game menu on Android #107389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 11, 2025

A few editor shortcuts were added to the GameView constructor in #103841. That constructor however is not invoked on Android, causing the shortcuts to be missing.
To address that, the shortcuts were moved to the GameViewDebugger constructor, which is invoked on Android.

Fixes the following error logs:

22:33:33.577  9300-9330  godot                    E  ERROR: Used ED_GET_SHORTCUT with invalid shortcut: editor/suspend_resume_embedded_project
22:33:33.577  9300-9330  godot                    E     at: ED_GET_SHORTCUT (editor/editor_settings.cpp:1961)
22:33:33.577  9300-9330  godot                    E  ERROR: Condition "p_shortcut.is_null()" is true. Returning: Array()
22:33:33.577  9300-9330  godot                    E     at: serialize_key_shortcut (core/debugger/debugger_marshalls.cpp:148)
22:33:33.577  9300-9330  godot                    E  ERROR: Used ED_GET_SHORTCUT with invalid shortcut: editor/next_frame_embedded_project
22:33:33.577  9300-9330  godot                    E     at: ED_GET_SHORTCUT (editor/editor_settings.cpp:1961)
22:33:33.577  9300-9330  godot                    E  ERROR: Condition "p_shortcut.is_null()" is true. Returning: Array()
22:33:33.577  9300-9330  godot                    E     at: serialize_key_shortcut (core/debugger/debugger_marshalls.cpp:148)

@m4gr3d m4gr3d added this to the 4.5 milestone Jun 11, 2025
@m4gr3d m4gr3d requested review from Alex2782, syntaxerror247 and a team June 11, 2025 05:35
@m4gr3d m4gr3d force-pushed the fix_game_menu_editor_shortcut_on_android branch from 0e7c834 to f4a2e9b Compare June 11, 2025 05:35
Copy link
Member

@syntaxerror247 syntaxerror247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and resolve the issue.

@akien-mga akien-mga merged commit 9282ed3 into godotengine:master Jun 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_game_menu_editor_shortcut_on_android branch June 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants