-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Fix TabContainer Editor theming and remove Debugger style hacks #107395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
07de208
to
1f0c792
Compare
1f0c792
to
2602148
Compare
Thanks for pointing that out, I just made it so theres only one BottomPanel stylebox with normal margins, and the Debugger panel now affects the top margin. This fully removes the extra cases in BottomPanel and the extra StyleBox. |
9da8da3
to
100002a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
Once we have EditorDock class, this could be probably automatic.
100002a
to
78045df
Compare
While working on another PR I realized that I missed a reference to the deleted stylebox in |
See: #106164 (comment), #104676 (comment)
This PR fixes a bug in the TabContainer theming, where
make_flat_stylebox(p_config.dark_color_1, 0, 0, 0, 0, p_config.corner_radius * EDSCALE)
was called to create the stylebox for the TabBar background, butmake_flat_stylebox
multiplies all the input values byEDSCALE
, soEDSCALE
was incorrectly applied twice. With the change applied, thetabbar_background
stylebox completely covers the bottom panel, meaning that there is no need for the negative extended margin that the Debugger's hack used previously, just the zero margins.This allows for the hacks used to create the Debugger panel's margins (the
BottomPanelDebuggerOverride
stylebox) to be removed completely.