Skip to content

Vulkan Mobile: Fix reading builtins in light() of spatial shader #107404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

beicause
Copy link
Contributor

Fixes #107403

@beicause beicause requested a review from a team as a code owner June 11, 2025 13:01
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 11, 2025
@beicause beicause force-pushed the mobile-spatial-light-shader-builtins branch 3 times, most recently from 440120a to a6a5b84 Compare June 11, 2025 13:21
@akien-mga akien-mga requested a review from DarioSamo June 11, 2025 13:22
@beicause beicause force-pushed the mobile-spatial-light-shader-builtins branch from a6a5b84 to a5ecf9c Compare June 11, 2025 13:31
@beicause beicause force-pushed the mobile-spatial-light-shader-builtins branch from a5ecf9c to 2a1d2af Compare June 11, 2025 13:33
Copy link
Contributor

@DarioSamo DarioSamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akien-mga akien-mga merged commit 9eda3c6 into godotengine:master Jun 12, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@beicause beicause deleted the mobile-spatial-light-shader-builtins branch June 12, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial shader compilation failed when reading ALBEDO in light() in Mobile renderer
4 participants