Move editor naming settings out of project settings #107405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The settings' original descriptions need to be moved to the editor settings, but I gather they would completely lose their descriptions in this PR? |
KoBeWi
force-pushed
the
settings_of_project_editor
branch
from
a9c2d4a to
1250ebb
Compare
Mickeon
reviewed
Jun 11, 2025
KoBeWi
force-pushed
the
settings_of_project_editor
branch
from
1250ebb to
ebce97e
Compare
Mickeon
reviewed
Jun 11, 2025
| @@ -2203,6 +2227,8 @@ void EditorSettings::_bind_methods() { | |||
| ClassDB::bind_method(D_METHOD("get_changed_settings"), &EditorSettings::get_changed_settings); | |||
| ClassDB::bind_method(D_METHOD("mark_setting_changed", "setting"), &EditorSettings::mark_setting_changed); | |||
|
|
|||
| ClassDB::bind_method(D_METHOD("_define_from_project_setting"), &EditorSettings::define_from_project_setting); | |||
There was a problem hiding this comment.
It's needed to use call(), to avoid including the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #107156, but instead moves
editor/namingsettings.I also made setting compatibility more explicit.