Skip to content

GDScript: Add missing type conversions in for range #107416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

GDScript: Add missing type conversions in for range #107416

merged 1 commit into from
Jun 12, 2025

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.5 milestone Jun 11, 2025
@dalexeev dalexeev requested a review from a team as a code owner June 11, 2025 17:48
@dalexeev dalexeev added the bug label Jun 11, 2025
@dalexeev dalexeev requested a review from a team as a code owner June 11, 2025 17:48
@akien-mga akien-mga requested a review from vnen June 11, 2025 22:32
lawnjelly
lawnjelly approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my area, but giving it a go as it is release blocker.

From what I can see this looks good. 👍
(Obviously if @vnen can get to see it too, is better.)

@akien-mga akien-mga merged commit ea908f1 into godotengine:master Jun 12, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-for-range-assignment branch June 13, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawnjelly lawnjelly lawnjelly approved these changes

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
bug regression topic:gdscript
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Infinite loop when using Rect2 and range()
3 participants
@dalexeev @akien-mga @lawnjelly