Skip to content

Fix error when updating a global animation library list #107430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix error when updating a global animation library list #107430

wants to merge 1 commit into from
+4 −1

Conversation

YeldhamDev
Copy link
Member

No description provided.

@YeldhamDev YeldhamDev added this to the 4.5 milestone Jun 11, 2025
@YeldhamDev YeldhamDev added bug regression cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 11, 2025
@YeldhamDev YeldhamDev mentioned this pull request Jun 11, 2025
Open
@akien-mga akien-mga requested a review from a team June 11, 2025 23:13
lyuma
lyuma reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the reproduction steps to the exact issue this is fixing? When does cur_lib become null? (How can I test this fix)

@YeldhamDev YeldhamDev force-pushed the anim_lib_global_fix branch from 1252453 to bd68ae0 Compare July 1, 2025 16:39
@YeldhamDev
Copy link
Member Author

@lyuma A quick way to reproduce it is to try to make an animation unique. Like you said yourself in your issue report.

@fire fire requested a review from a team July 1, 2025 20:43
@fire fire moved this to Ready for review in Animation Team Issue Triage Jul 1, 2025
@YeldhamDev YeldhamDev force-pushed the anim_lib_global_fix branch from bd68ae0 to a87b096 Compare July 7, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuma lyuma lyuma left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release regression topic:animation topic:editor
Projects
Animation Team Issue Triage
Status: Ready for review
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @lyuma @akien-mga