Skip to content

[Editor] Use Icons for FindInFiles Buttons #107431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lodetrick
Copy link
Contributor

This PR replaces the text in FindInFiles with icons and a short tooltip. This bring the FindInFiles more in line with the rest of the editor docks that use icons for these methods.

This PR Specifically changes the buttons in the top right:

Before After
Screenshot 2025-06-11 at 5 09 27 PM Screenshot 2025-06-11 at 5 07 25 PM

@AThousandShips AThousandShips added this to the 4.x milestone Jun 12, 2025
@AThousandShips AThousandShips requested a review from a team June 12, 2025 07:24
@lodetrick lodetrick force-pushed the find-in-files-icons branch from 8fb1fda to a7a85ac Compare June 12, 2025 18:59
Copy link
Contributor

@arkology arkology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not test from commit artifacts (GH actions are stuck), but code and changes overall (I suggested them in #104676 (comment)) LGTM.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 17, 2025

This bring the FindInFiles more in line with the rest of the editor docks that use icons for these methods.

Theme editor does not use icons.

I'm not sure about this change. The buttons are not prominent enough and somewhat blend with the text next to them, making them potentially easy to miss. Also the closing X is next to the other X buttons, which have completely different function; it can be confusing.

@AThousandShips
Copy link
Member

I think this hurts usability, also what other docs are you referring to? The only dock I can find that has a button for closing uses "Close"

@arkology
Copy link
Contributor

Theme editor does not use icons.

BTW I have a branch with such changes. For ThemeEditor I think it suits better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants