Fix FileSystemDock signal connection for path navigation text box #107434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodetrick
force-pushed
the
filedock-signal
branch
from
1204b03 to
5d98cee
Compare
AThousandShips
approved these changes
Jun 12, 2025
akien-mga
changed the title
akien-mga
force-pushed
the
filedock-signal
branch
from
5d98cee to
28c2bad
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current master, clicking the filepath textbox and entering a filepath throws an error:
ERROR: Error calling from signal 'text_submitted' to callable: 'FileSystemDock::FileSystemDock::_navigate_to_path': Method expected 3 arguments, but called with 2.This was caused because #106049 added another default parameter to the
_navigate_to_pathmethod, but the signal connection was not updated accordingly. This PR updates the connect call to properly create the callable, so it doesn't throw errors anymore. It chooses thetruevalue to give focus to the file that you just navigated to.