Move binary math functions to Math namespace in math_funcs_binary.h
#107452
+331
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
bit-math-header
branch
2 times, most recently
from
4210412 to
48dcecc
Compare
Ivorforce
force-pushed
the
bit-math-header
branch
from
48dcecc to
0e12e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our efficient binary math functions have been living in
typedefs.h. However, they have slowly reproduced and multiplied, and are now threatening to overwhelm the rest of thetypedefs.hbiome. The latest introduction of #106606 has near doubled their number again.To ensure the survival of the rest of the habitat, we must move the functions to their own enclosed living space.
I've selected the existing
Mathnamespace for this purpose, but have chosen to make a separatemath_funcs_binary.hheader, rather than adding tomath_funcs.h. The reason is that callers will likely have little overlap: Collections and low level code are usually interested in binary math, but not normal math, while math code is usually interested in generalized math, and likely won't be using the binary-based functions.