Display AnimationTree editor warnings when the node is disabled #107468
+28
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be better to have a method in AnimationTree that returns error string, instead of repeating the same thing 4 times. |
Calinou
force-pushed
the
editor-animationtree-warn-disabled
branch
from
be1ee9a to
70812c7
Compare
KoBeWi
reviewed
Jun 25, 2025
AnimationTree's Active property isn't the only way to control whether an AnimationTree can play animations. Node's Process Mode property also affects it.
Calinou
force-pushed
the
editor-animationtree-warn-disabled
branch
from
70812c7 to
607a9a4
Compare
KoBeWi
reviewed
Jul 2, 2025
| } else if (blend_space->get_triangle_count() == 0) { | ||
| error = tree->get_editor_error_message(); | ||
|
|
||
| if (blend_space->get_triangle_count() == 0) { |
There was a problem hiding this comment.
To preserve the previous behavior, you should also check whether error is empty here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnimationTree's Active property isn't the only way to control whether an AnimationTree can play animations. Node's Process Mode property also affects it.
Preview