Only repath a NavigationAgent with a target position #107513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only repaths a NavigationAgent with a target position.
akien-mga
approved these changes
Jun 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only repaths a NavigationAgent with a target position.
Resolves #101232
It is correct that a repath should happen when the
navigation_layersor navigationmapchanges as the old path can become invalid with such a change.However a repath only makes sense while an agent is intended to follow a path already, aka has a
target_positionset.There shouldn't be a path update without a target_position. The agent can do nothing with such a path. As can be seen by the linked issue all it does is set the wrong internal pathfollowing state.