Skip to content

Create AudioStreamEffect #107523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoyBerardo
Copy link
Contributor

This adds a new AudioStream type, AudioStreamEffect, which applies audio bus effects directly to audio streams.

image

This partially addresses godotengine/godot-proposals#8190 ("Partially" because i believe it would be useful to apply effects to audio stream players, but that is a whole other topic)

Effects can be individually bypassed. By enabling process_bypassed_effects, bypassed effects will still process so bypassing and un-bypassing effects like reverb won't result in a burst of sound.

When the child stream is finished playing, this stream fades out for the duration of tail_time, allowing effects like reverb and delay to fade out.

This is currently a draft because I feel it would be useful to get community input on this new stream type. Some things I'd like to get some thoughts/discussion on in particular:

  • Should process_bypassed_effects be per-effect? That would allow for more granular control but I worry about cluttering the effect list.
  • Instead of tail_fade_curve, should there instead just be a bool that simply enables/disables a fade on the tail?
  • Would appreciate it if someone looked over the docs I made, I'm not the best at writing those.
  • AudioEffect docs would need to be updated since they talk about audio effects only in the context of busses.

@RoyBerardo RoyBerardo force-pushed the audio_stream_effect branch from 5173a05 to f0ee52c Compare June 14, 2025 09:57
@RoyBerardo RoyBerardo changed the title create AudioStreamEffect Create AudioStreamEffect Jun 14, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants