Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
AudioStream
type,AudioStreamEffect
, which applies audio bus effects directly to audio streams.This partially addresses godotengine/godot-proposals#8190 ("Partially" because i believe it would be useful to apply effects to audio stream players, but that is a whole other topic)
Effects can be individually bypassed. By enabling
process_bypassed_effects
, bypassed effects will still process so bypassing and un-bypassing effects like reverb won't result in a burst of sound.When the child stream is finished playing, this stream fades out for the duration of
tail_time
, allowing effects like reverb and delay to fade out.This is currently a draft because I feel it would be useful to get community input on this new stream type. Some things I'd like to get some thoughts/discussion on in particular:
process_bypassed_effects
be per-effect? That would allow for more granular control but I worry about cluttering the effect list.tail_fade_curve
, should there instead just be a bool that simply enables/disables a fade on the tail?