Skip to content

Improve ResourceLoader.get_dependencies()'s description #107554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

timothyqiu
Copy link
Member

The example code made me wonder what happened to the second slice, so I looked into the source code and improved the documentation.

The second section is optional. It contains the dependency's type info when p_add_type is true. But the option is never exposed to scripting, so the second section is always empty.

@timothyqiu timothyqiu added this to the 4.x milestone Jun 15, 2025
@timothyqiu timothyqiu requested a review from a team as a code owner June 15, 2025 09:11
@RedMser
Copy link
Contributor

RedMser commented Jun 15, 2025

ResourceFormatLoader::_get_dependencies docs could also be updated the same way for consistency.

@timothyqiu timothyqiu force-pushed the depstr branch 2 times, most recently from 4d52de4 to 27b8e7a Compare June 15, 2025 11:35
@Mickeon Mickeon modified the milestones: 4.x, 4.5 Jun 16, 2025
@Repiteo Repiteo merged commit dd3ae0b into godotengine:master Jun 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 18, 2025

Thanks!

@timothyqiu timothyqiu deleted the depstr branch June 19, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants