Skip to content

Allow fixing indirect missing dependencies manually #107580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jun 16, 2025

Currently, the dependency error dialog is only shown for missing dependencies that are referenced directly by the opening scene. Therefore, if the missing dependency is deeply nested, manually fixing it becomes cumbersome. I guess this is the main reason we devote to improving automatic solutions. However, there are situations where manual fixing is inevitable.

This PR lists all missing items related to the current scene in the Dependency Errors dialog. It also allows the user to open the corresponding dependency editing dialog directly from this dialog, so that they don't have to manually locate them one by one in the file system.

deps-demo.mp4

Note: Ideally, fixing one missing resource should ideally fix all references to it automatically. However, this would involve a complete refactoring of the dependency editing dialog. I think that could be a separate PR.

Test project with several missing dependencies: deps-mrp.zip

Closes godotengine/godot-proposals#12681

@timothyqiu timothyqiu added this to the 4.x milestone Jun 16, 2025
@AThousandShips AThousandShips requested a review from a team June 16, 2025 08:25
@KoBeWi
Copy link
Member

KoBeWi commented Jun 25, 2025

Resource name seems to be getting disproportionately more space.
image
The ratio should be reversed.

@timothyqiu
Copy link
Member Author

timothyqiu commented Jun 26, 2025

Resource name seems to be getting disproportionately more space.
The ratio should be reversed.

It's been using this ratio since 4.0 😆

Updated & changed the ratio to 1:1, so it's the same as 3.x.

I guess this also shows the need for being able to set a special ellipsis position for paths: godotengine/godot-proposals#9598

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI/UX] Improve behavior of "Load failed due to missing dependencies windows"
2 participants