Add qualifier for multilevel methods #107604
Open
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Jun 16, 2025
There was a problem hiding this comment.
The need for this new qualifier should be discussed. I personally think it's overkill and a bit difficult to spot. It's also the only qualifier that needs to be added manually. If there were even more methods that are an exception to the norm, I can see this making more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #107564
This adds a hard-coded qualifier that can be used to mark multilevel methods.
It's hard-coded, because the multilevel logic exists only in GDCLASS, AFAIK it's not even a thing in any language. We rarely add multilevel methods (last one was almost 3 years ago), so adding the qualifier manually is fine in this case.
_property_can_revert()needs to be double-checked, it is multilevel in core, so it's weird it's not in scripts._validate_property()is multilevel only in core, which is likely a bug.