GPUParticles2D: Fix Collision shape for Animated Particles #107614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:2d
topic:particles
cherrypick:4.3
- change ptr to Ref counted object
cosparks
force-pushed
the
fix-animated-2d-gpu-particle-animations
branch
from
9e0b0d2 to
7948733
Compare
|
The solution looks fine, but the collision does not update when you modify the material. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just going through older particles issues and came across #91523, which is still reproducible on latest master (currently 46c495c). The reporter proposed a sensible solution afaict, and I don't see any reason that it shouldn't be merged.
closes #91523