Skip to content

Fix Quaternion(arc_from: Vector3, arc_to: Vector3) behaves differently in gdscript and c# #107618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix Quaternion(arc_from: Vector3, arc_to: Vector3) behaves differently in gdscript and c# #107618

merged 1 commit into from
Jun 27, 2025

Conversation

DanielGSilva
Copy link
Contributor

Fixes #107595

@DanielGSilva DanielGSilva requested a review from a team as a code owner June 17, 2025 07:47
@AThousandShips AThousandShips added bug topic:dotnet cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 17, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 17, 2025
AThousandShips
AThousandShips reviewed Jun 17, 2025
View reviewed changes
aaronfranke
aaronfranke requested changes Jun 17, 2025
View reviewed changes
@DanielGSilva
Copy link
Contributor Author

DanielGSilva commented Jun 18, 2025 •
edited
Loading

Went ahead and changed it into what @beicause posted, with the correction in Basis.

@DanielGSilva DanielGSilva requested a review from aaronfranke June 18, 2025 07:59
raulsntos
raulsntos requested changes Jun 18, 2025
View reviewed changes
@DanielGSilva DanielGSilva requested a review from raulsntos June 18, 2025 16:30
raulsntos
raulsntos approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few naming nit-picks, otherwise looks good to me. The code matches the C++ implementation and seems to work as expected checking with the MRP.

aaronfranke
aaronfranke reviewed Jun 26, 2025
View reviewed changes
@DanielGSilva DanielGSilva requested a review from aaronfranke June 26, 2025 08:58
aaronfranke
aaronfranke approved these changes Jun 26, 2025
View reviewed changes
aaronfranke
aaronfranke approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test but this looks good to me.

@Repiteo Repiteo merged commit dc41b31 into godotengine:master Jun 27, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 27, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@DanielGSilva
Copy link
Contributor Author

Thanks for all the help!

(I had already made a contribution in #101066 but I think the commit author was a different account of mine and that's why it showed this as my first again)

@DanielGSilva DanielGSilva deleted the quat-arc branch June 27, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beicause beicause beicause left review comments

@AThousandShips AThousandShips AThousandShips left review comments

@aaronfranke aaronfranke aaronfranke approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:dotnet
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Quaternion(arc_from: Vector3, arc_to: Vector3) behaves differently in gdscript and c#
6 participants
@DanielGSilva @Repiteo @aaronfranke @raulsntos @beicause @AThousandShips