Autocompletion: Don't use next for GET_NODE inference
#107636
Merged
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
the
cherrypick:4.4
akien-mga
changed the title
next for GET_NODE inferencenext for GET_NODE inference
Mickeon
reviewed
Jun 17, 2025
| @@ -3142,8 +3142,21 @@ static bool _get_subscript_type(GDScriptParser::CompletionContext &p_context, co | |||
| } | |||
| } break; | |||
| case GDScriptParser::IdentifierNode::Source::LOCAL_VARIABLE: { | |||
| if (identifier_node->next != nullptr && identifier_node->next->type == GDScriptParser::ClassNode::Node::GET_NODE) { | |||
| get_node = static_cast<GDScriptParser::GetNodeNode *>(identifier_node->next); | |||
| // TODO: Do basic assignment flow analysis like in `_guess_expression_type`. | |||
There was a problem hiding this comment.
What do you mean by the comment?
There was a problem hiding this comment.
The standard code path for type detection takes assignments into account when picking the expression from which to guess the type.
var a
a = "hello"
a. # suggests string methodsThis special code path for GET_NODE does not do that right now and only works with the initializer of the variable.
But to support that without duplicating a lot of code, we'd probably need to remove _get_subscript_type and integrate GET_NODE into the standard _guess_expression_type code path. So it isn't a quick fix, which is why I just added a comment about it for now.
vnen
approved these changes
Jul 1, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107626
Node->nextis a parser detail and has no semantic meaning. Using it for completion or analyzing is highly unreliable.