Skip to content

Update CI ruff pre-commit hooks #107665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Conversation

Chubercik
Copy link
Contributor


No changes across the repo required, simple version bump.

@Chubercik Chubercik requested a review from a team as a code owner June 18, 2025 11:01
@AThousandShips AThousandShips added this to the 4.x milestone Jun 18, 2025
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to increase the min supported Python version, so should be fine.
https://github.com/astral-sh/ruff/releases/tag/0.12.0

@akien-mga akien-mga modified the milestones: 4.x, 4.5 Jun 18, 2025
@Ivorforce
Copy link
Member

Ivorforce commented Jun 18, 2025

Just to be sure, does this change any formatting? We had a few formatter version bumps that left the repo in a dirty state afterwards.

@Repiteo Repiteo merged commit 16ea984 into godotengine:master Jun 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 18, 2025

Thanks!

@Chubercik
Copy link
Contributor Author

It doesn't seem to increase the min supported Python version, so should be fine.

Yeah, the minimum Python version for using ruff remains 3.7 afaik.

Just to be sure, does this change any formatting? We had a few formatter version bumps that left the repo in a dirty state afterwards.

Yup, ever since it slipped by me one time, I always run pre-commit run -a before committing, so everything should be fine.

@Chubercik Chubercik deleted the ci/bump-ruff branch June 19, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants