Check UID to disable "Set as Main Scene" in FileSystemDock #107686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Jun 20, 2025
vaner-org
force-pushed
the
filesystem-main-scene-check-uid
branch
from
f612e5a to
2a8ab47
Compare
Correctly removes "Set as Main Scene" in FileSystemDock's right-click menu for when main scene was set with a uid:// path.
vaner-org
force-pushed
the
filesystem-main-scene-check-uid
branch
from
2a8ab47 to
472bc68
Compare
KoBeWi
approved these changes
Jun 20, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly removes "Set as Main Scene" in FileSystemDock's right-click menu for when main scene was set with a
uid://path.At the moment, Set as Main Scene's if statement expects a
res://path, which means for any way in the editor that a main scene is set after 4.4, the right-click option for "Set as Main Scene" always remains, including when set from the option itself.