Skip to content

Adjust names of new XRBodyTracker joints #107715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

devloglogan
Copy link
Contributor

I added some new joints in #107220 to be used with an extension like XR_META_body_tracking_full_body, but realized later that the OpenXR ankle joint should be mapped to the Godot humanoid foot joint. This PR renames the new ankle twist joints to foot twist, and instead of adding ankle joints it adds heel joints. This aligns better with Godot humanoid.

@devloglogan devloglogan added this to the 4.5 milestone Jun 19, 2025
@devloglogan devloglogan requested review from a team as code owners June 19, 2025 13:03
@dsnopek dsnopek added the bug label Jun 19, 2025
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me :-)

@Repiteo Repiteo merged commit 7168009 into godotengine:master Jun 19, 2025
39 of 40 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants