Make Hexagonal tiles rotate 180 degrees to fit grid

[TheSofox]

Fixes #107510

Normally, clicking a "rotate left" or "rotate right" button for a tile in a grid would rotate it 90 degrees. This was fine for square tiles, but would make hexagonal tiles not fit the grid properly. This PR makes hexagonal tiles only rotate 180 degrees when the button is pushed, so it still fits. (making them rotate by 60 degrees would have been ideal, but comes with additional complications).

[Chubercik]

(making them rotate by 60 degrees would have been ideal, but comes with additional complications).

Could you elaborate on that? Like you said, that would seem ideal.

[TheSofox]

(making them rotate by 60 degrees would have been ideal, but comes with additional complications).

Could you elaborate on that? Like you said, that would seem ideal.

1. The tiles don't have a "rotate" property, only a "flip_h", "flip_y" and "transpose" (transpose rotates tile 90 degrees counter-clockwise and then flipped vertically according to here: https://docs.godotengine.org/en/stable/tutorials/2d/using_tilesets.html#doc-using-tilesets-creating-alternative-tiles ). These three properties are used to rotate a regular square tile in the 4 main directions, but can't be easily adjusted to make them 60 degree rotations
2. Rotating 60 degrees would introduce rotation artifacts. It would not be pixel perfect.

[kleonc]

Not sure if this is a good change. For a full-hex tile rotating by 90° doesn't make much sense indeed (as it won't fit the hex grid), but note that the tile visuals might be not matching the tile shape, e.g. it could be only some prop/item in the middle of the tile etc. Thus I'm not sure if 90° rotations are always undesired.
If anyone is using 90° tile rotations with hex grid (no idea if that's the case) then this PR would introduce a regression for them (only regarding the editor usability though, as it's still possible to manually set any transform flags using a script).

AFAICT #107510 is mainly about not being able to rotate by 60°. Being able to rotate hex-tiles by 90° would probably be a non-issue if it would be possible to switch between 90°/60° rotations (and 60° would be the default mode for hexes). Aka I consider 90° rotations for hex tiles as an additional option/feature, not sure if disallowing it editor-wise is a correct solution here, even given 60° rotations are currently not supported at all.

Just something to consider before merging. 🙃

[kleonc]

Note that the changes make this comment partially outdated (same for case TRANSFORM_ROTATE_RIGHT), as it refers only to 90° rotations, which now is not what would be always performed.

[groud]

If anyone is using 90° tile rotations with hex grid (no idea if that's the case) then this PR would introduce a regression for them (only regarding the editor usability though, as it's still possible to manually set any transform flags using a script).

Ah yeah, I guess that if you have some tiles that are not, like, hexagon-shaped, it make sense... Well that I guess we'll have to keep the "feature" then.