[3.x] libwebm: Fix double free in mkvparser ContentEncoding #107781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
|
Any reason this targets 3.6 and not 3.x? Is it not relevant to 3.x (future 3.7)? |
|
Indeed this should be fixed in the |
akien-mga
changed the title
akien-mga
changed the title
akien-mga
changed the title
akien-mga
added
bug
topic:thirdparty
cherrypick:3.5
Origin: webmproject/libvpx@6a7c84a Author: James Zern <[email protected]> ----- This is a security fix for CVE-2019-2126. Godot currently contains a vulnerable version of libwebm in its 3.x branch that is susceptible to a double free due to a missing reset of a freed pointer. This commit corrects that issue.
|
I changed the base branch to |
akien-mga
approved these changes
Jun 21, 2025
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 3.6.1. |
akien-mga
removed
the
cherrypick:3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin: webmproject/libvpx@6a7c84a
Author: James Zern [email protected]
This is a security fix for CVE-2019-2126. Godot currently contains a vulnerable version of libwebm in its 3.6 branch that is susceptible to a double free due to a missing reset of a freed pointer. This commit corrects that issue.