Revert "Rework scene preview thumbnails" #107786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #102313 (and some fixup PRs) as discussed in #102313 (comment).
The feature (better scene previews) is great and wanted, but we need more time to iron out the implementation and have it tested thoroughly. We merged #102313 just before the feature freeze for 4.5 beta, which wasn't a great timing given its scope (that was underestimated).
So we roll it back for 4.5 instead of attempting to pile more fixes in a short timespan, which would put unnecessary pressure on @daniel080400 (who authored the PR) and other maintainers.
Thanks so much to @daniel080400 for the implementation, and the great work on fixing up regressions after merge! This revert shouldn't be seen as a rejection of the feature, just a delay to give ourselves more time to iterate.
We would very much like to see the reverted PR recreated, taking into account the bug reports and suggestions for improvement, so we can continue reviewing and testing, and aim to merge it early in the next dev cycle (4.6) if it's ready.
save_on_focus_loss
is enabled #107397 (with an extra change to revert this line made necessary by this commit: https://github.com/godotengine/godot/pull/103972/files#diff-b88f0bde58b731e8dd353707c8011fb7a1e452f0db2c9f15f4b7905d60e5e52eR2139 )PackedScene
cache when generating scene preview thumbnails #107514SubViewport
nodes in thumbnail preview scene #107676EditorPreviewPlugin
#107689thumbnail_progress
slowdown by batching_iterate()
calls. #107744