Skip to content

Revert "Rework scene preview thumbnails" #107786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jun 20, 2025

Reverts #102313 (and some fixup PRs) as discussed in #102313 (comment).

The feature (better scene previews) is great and wanted, but we need more time to iron out the implementation and have it tested thoroughly. We merged #102313 just before the feature freeze for 4.5 beta, which wasn't a great timing given its scope (that was underestimated).

So we roll it back for 4.5 instead of attempting to pile more fixes in a short timespan, which would put unnecessary pressure on @daniel080400 (who authored the PR) and other maintainers.

Thanks so much to @daniel080400 for the implementation, and the great work on fixing up regressions after merge! This revert shouldn't be seen as a rejection of the feature, just a delay to give ourselves more time to iterate.

We would very much like to see the reverted PR recreated, taking into account the bug reports and suggestions for improvement, so we can continue reviewing and testing, and aim to merge it early in the next dev cycle (4.6) if it's ready.

This reverts commit 0834318.

While the feature is great, a number of issues have been found with the
implementation, and we need more time to resolve them.

So we roll this back for 4.5, to rework the feature for a later Godot
release.
@akien-mga akien-mga added this to the 4.5 milestone Jun 20, 2025
@akien-mga akien-mga requested review from a team as code owners June 20, 2025 22:31
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature, and amazing job from a first time contributor, unfortunately it didn't get the testing and love it deserved, but we still want it! I will try my best to help when it comes to getting it back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment