Skip to content

Improve auto-translation of the rendering method selector #107795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jun 21, 2025

Follow-up to #107624
Part of #104574

  • Some simple refactoring are done in order to make the button auto-translatable.
  • Removed two unnecessary member variables.
    • renderer_request: bind as callback argument instead.
    • renderer_current: can be determined by checking the current project settings.
  • Made the rendering method change confirm dialog lazy-created.

@timothyqiu timothyqiu force-pushed the renderer-selection-i18n branch from 61bf8fa to 6c06497 Compare July 9, 2025 04:41
@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants