Skip to content

NavigationServer2D: Bind missing merge_rasterizer_cell_scale setting and functions #107802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

Notgoyome
Copy link
Contributor

fixes: #107771

This PR fixes an error from nav_map2D and adds binding methods.

nav_map2D doesn't use any settings for merge_rasterizer_cell_scale so it's always 1 by default.

I added the setting navigation/2d/merge_rasterizer_cell_scale with same property as the 3d one.
and make navigation map server2D init with this value.

I also added binding method map_set_merge_rasterizer_cell_scale and map_get_merge_rasterizer_cell_scale.

@Notgoyome Notgoyome changed the title Fix: make nav_map_2d uses rasterizer cell scale options in 2d navigat… Fix nav_map_builder_2d error in warning message Jun 21, 2025
@Notgoyome Notgoyome marked this pull request as ready for review June 21, 2025 15:05
@Notgoyome Notgoyome requested review from a team as code owners June 21, 2025 15:05
@smix8 smix8 added this to the 4.5 milestone Jun 21, 2025
@akien-mga akien-mga changed the title Fix nav_map_builder_2d error in warning message NavigationServer2D: Bind missing merge_rasterizer_cell_scale setting and functions Jun 22, 2025
@akien-mga akien-mga merged commit 2e170c4 into godotengine:master Jun 22, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nav_map_builder_2d little error in a warning message
3 participants