Skip to content

Tree: Fix handling of __focus_rect with various Select Modes #107834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

BrotherShort
Copy link
Contributor

Fix #107661

Under what conditions does the Tree update the meta data "__focus_rect"?

before #33286 :

Tree Select Mode Selected Cells Selected Row Selected Col Cell Selected Row Other Cells
Single
Row × × ×
Multi

After #33286 :

Tree Select Mode Selected Cells Selected Row Selected Col Cell Selected Row Other Cells
Single × ×
Row
Multi × ×

After #106286:

Tree Select Mode Selected Cells Selected Row Selected Col Cell Selected Row Other Cells
Single × ×
Row
Multi

Now:

Tree Select Mode Selected Cells Selected Row Selected Col Cell Selected Row Other Cells
Single × ×
Row
Multi ×

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new condition handles all 3 select modes, so it should be much more reliable.
It does not bring back other regressions, and I checked some other Trees and they seem to work fine.

@akien-mga akien-mga changed the title Fix rename autoloads Tree: Fix handling of __focus_rect with various Select Modes Jun 22, 2025
@akien-mga akien-mga merged commit d7bdc0b into godotengine:master Jun 22, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't rename autoloads
3 participants