Skip to content

Fix can't convert to ShaderMaterial in FileSystemDock #107842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

beicause
Copy link
Contributor

Fixes #107833

Likely a regression from #106041 according to blame history

@beicause beicause requested a review from a team as a code owner June 22, 2025 12:11
@BlueCube3310 BlueCube3310 added this to the 4.5 milestone Jun 22, 2025
@BlueCube3310
Copy link
Contributor

Tested locally, the fix only works when the file system dock is in "vertical" mode. When moved to the bottom, it still doesn't work.

@beicause beicause force-pushed the Fix-can't-convert-to-ShaderMaterial-in-FileSystemDock branch from 75391fb to 76dfe01 Compare June 22, 2025 13:03
@beicause beicause force-pushed the Fix-can't-convert-to-ShaderMaterial-in-FileSystemDock branch from 76dfe01 to 4eba912 Compare June 22, 2025 13:15
@beicause beicause force-pushed the Fix-can't-convert-to-ShaderMaterial-in-FileSystemDock branch from 4eba912 to 52dae12 Compare June 23, 2025 01:17
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I included part of this fix in #106040, but I didn't expect it to be merged first 😅

@Repiteo Repiteo merged commit 7c32170 into godotengine:master Jun 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.5] Can't convert StandardMaterial3D to ShaderMaterial in FileSystemDock
4 participants