[3.x] Optimize Object::cast_to
with ancestral classes when possible
#107844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object
ancestry #107462 (comment)This implementation should be several times faster than regular
Object::cast_to
, for classes with corresponding ancestral classes (although i have not tested this).It would be possible to "pre-check" the types that derive from any of the ancestral types (e.g.
object && object.has_ancestry(AncestralClass::SPATIAL) && object.is_class_ptr(SpatialSubclass::get_class_ptr_static())
). But that would only accelerate the unhappy path, and only some of the time. The happy path wants to immediately useis_class_ptr
, so I decided against this micro optimization.The
_is_class
function should useconstexpr
, but it's not possible until the upgrade to C++17.4.x equivalent will follow for 4.6, when
AncestralClass
is forward ported.