Simplify and optimize call arguments from generic parse_class_body()
#107849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
parse_class_body()parse_class_body()
Ivorforce
requested changes
Jun 22, 2025
| @@ -876,13 +876,13 @@ bool GDScriptParser::has_class(const GDScriptParser::ClassNode *p_class) const { | |||
| return false; | |||
| } | |||
|
|
|||
| GDScriptParser::ClassNode *GDScriptParser::parse_class(bool p_is_abstract, bool p_is_static) { | |||
| GDScriptParser::ClassNode *GDScriptParser::parse_class(int p_flags) { | |||
There was a problem hiding this comment.
This (and other places where you want to pass these flags) should use BitField. Passing flags in a plain int doesn't provide enough static safety.
|
I'm against refactoring just for the sake of it. There's no reason to believe we'll be adding more flags in the future. The |
|
dunno why but when I used the BitField some tests returned incorrect results. Closed and removed the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calls called in
parse_class_body()requires a series of booleans, which would lead to problems, especiallyparse_variables()as it has a overloading version with 3 booleans, which has potential conflict with the one with 2 booleans.In this pr, these calls receive only one
intargument as flags. Not only do the arguments get reduced, but this solves the conflict mentioned above.