Ensure sky orientation is set when reflection uses sky #107858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Forward+ and Mobile rendering backends, sky reflections were missing when the environment was configured with:
Clear ColororColor.Background.This was caused by the sky orientation transform (
radiance_inverse_xform) not being set in this specific configuration, even though theUSE_REFLECTION_CUBEMAPflag was correctly enabled.This change decouples the sky orientation logic from the ambient light setup. The
radiance_inverse_xformis now updated whenever either the ambient or reflection cubemap is in use.Fixes: #98487