[3.x] Optimize hotspots with Object::is_reference()
#107877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
commented
Jun 23, 2025
Ivorforce
reviewed
Jun 23, 2025
Ivorforce
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
Looks good to me.
I don't think we want to expose similar functions for other ancestral classes, but for Reference one I think it's fine because
ReferenceviolatesObject's life cycle, so it already kind of is fundamentally different.is_ref_countedexists in 4.x too
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x equivalent of
is_ref_counted()in 4.x.This is both easier to read, and faster in release (in case where pointer NULL check is not required) by 1.5x, and faster in debug because pointer check won't be optimized out.