Always apply SpringArm3D margin #107882
Open
Always apply SpringArm3D margin #107882
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the margin was only applied if both:
This would make the arm immediately jump to the margin position on collision. This pr always factors in the margin when determining the length. The margin also works now in the case that a shape is set or the child is a camera.
Similar to #89797 this is technically a breaking change because the margin didn't do anything before in some cases and the default value is not 0. On the other hand the default margin is very small (0.01).
Example setup:
margin == 1, csgbox.size == 0.8*0.8*0.8Old behaviour:
2025-06-23.00-28-47.mp4
New behaviour:
2025-06-23.00-27-49.mp4
Supersedes #89797
Fixes #76220