Specifiy return value in several store methods in FileAccess

[krishnabm]

Some of the store methods did not specify the nature of return bool value. Added it after referring to FileAccess.cpp method.

[krishnabm]

Helps with users cleaning up RETURN_VALUE_DISCARDED gdscript warnings in a jiffy.

[Mickeon]

It's not a good idea to make a whole new line for this. The sentence should be merged with the first line.

Although, since this is common information, it may be worth mentioning it once and for all in the leading description.

[krishnabm]

It's not a good idea to make a whole new line for this. The sentence should be merged with the first line.

Although, since this is common information, it may be worth mentioning it once and for all in the leading description.

Done. I couldn't find a suitable reference for adding this in the leading description of the method definitions. Let me know if this would make sense somewhere specific and I can include the following line in the description -
All store_* methods return a boolean value indicating success of the operation.

On the other hand, I feel it would be consistent to return the Error enum similar to other set_ and get_ methods. Is this something that can be added to the issue tracker? Also will it break backward compatibility?

[Mickeon]

On the other hand, I feel it would be consistent to return the Error enum similar to other set_ and get_ methods. Is this something that can be added to the issue tracker? Also will it break backward compatibility?

A quick skim through the code tells me the store methods may not need that much granularity. It would also break compatibility, indeed. Either way that's outside the scope of this PR.

[bruvzg]

A quick skim through the code tells me the store methods may not need that much granularity.

Undelaying platform API is also quite inconsistent and in many cases not capable of specifying exact reason of failure. Also, there's not much difference for the user. If the file write operation fails, the only thing you can do is close the file, it's non-recoverable.

[krishnabm]

So can this be merged then?
Let me know if there is anything else I need to do

[krishnabm]

Thanks!

[Repiteo]

Could you squash your commits? See our PR Workflow for more details:
https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase

[krishnabm]

Could you squash your commits? See our PR Workflow for more details: https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase

Thanks and done, will keep this in mind for the next time

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉