Skip to content

[3.x] Revert "FTI - Reduce VisualInstance xform notifications" #107949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jun 24, 2025

This reverts commit 5ec4fd3.

Fixes #107829
Fixes #107755

3.x version of #107854

IMPORTANT: I think we should merge this before building 3.7 alpha 1, to avoid regressions seen in 4.5 beta 1.

Notes

  • As with 4.x, I think it would be wise to do this a slightly different way, SoftBody in particular relies on this with its current hacky approach.
  • I'll revisit this to see if we can reduce these without causing regressions, it's not critical for 3.7 alpha 1.
  • As noted on the original PR, this area was experimental and prone to regressions (the reason for separating it into a self-contained PR in the first place).

@lawnjelly lawnjelly merged commit 1a7d99e into godotengine:3.x Jun 24, 2025
14 checks passed
@lawnjelly
Copy link
Member Author

Thanks!

@lawnjelly lawnjelly deleted the revert_reduce_xform_changed branch June 24, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants