Skip to content

[.NET] Avoid exporting to duplicate architectures #107987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

raulsntos
Copy link
Member

Use a HashSet to avoid adding duplicate architectures on exporting. It seems we were adding x86_64 and arm64 twice to macOS exports because they are also included in the features.

Use a `HashSet` to avoid adding duplicate architectures on exporting. It seems we were adding `x86_64` and `arm64` twice to macOS exports because they are also included in the features.
@raulsntos raulsntos added this to the 4.5 milestone Jun 25, 2025
@raulsntos raulsntos requested a review from a team as a code owner June 25, 2025 19:44
@raulsntos raulsntos added bug topic:dotnet topic:export cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 25, 2025
@Repiteo Repiteo merged commit 5256281 into godotengine:master Jun 25, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 25, 2025

Thanks!

@raulsntos raulsntos deleted the dotnet/avoid-duplicate-archs branch June 25, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:dotnet topic:export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while trying to export on macOS
3 participants