Skip to content

Block Tween custom_step() during step #108004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

Block Tween custom_step() during step #108004

merged 1 commit into from
Jun 28, 2025
+8 −2

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 26, 2025

Fixes #99441

@KoBeWi KoBeWi added this to the 4.5 milestone Jun 26, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner June 26, 2025 10:28
raulsntos
raulsntos approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the C# MRP from the issue, and I can confirm it no longer crashes. The code also looks reasonable to me, but it's no my area.

@akien-mga akien-mga merged commit ad00801 into godotengine:master Jun 28, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the tween_overflow branch June 28, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
bug topic:animation
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Calling Tween.custom_step() from within a tween freezes the game and produces an unclear fatal C++ error
4 participants
@KoBeWi @akien-mga @raulsntos @TokageItLab