Skip to content

Fix screen_accum not being reset when it should be in Input::VelocityTrack #108005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix screen_accum not being reset when it should be in Input::VelocityTrack #108005

merged 1 commit into from
Jun 27, 2025
+3 −0

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Jun 26, 2025 •
edited
Loading

Resets screen_accum like accum, resets screen_velocity like velocity.

Fix #107997.

@Rindbee
Fix screen_accum not being reset when it should be in `Input::Veloc…
efed435 
…ityTrack`

Resets `screen_accum` like `accum`.
@Rindbee Rindbee requested a review from a team as a code owner June 26, 2025 12:07
Sauermann
Sauermann approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me and I find it likely that it will resolve the linked bugreport.

@akien-mga akien-mga added this to the 4.5 milestone Jun 26, 2025
@Repiteo Repiteo merged commit f936033 into godotengine:master Jun 27, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 27, 2025

Thanks!

@Rindbee Rindbee deleted the reset-screen_accum branch June 28, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
bug topic:input
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Input.get_last_mouse_screen_velocity returns offset from program start (roughly), not velocity
4 participants
@Rindbee @Repiteo @Sauermann @akien-mga